London is large enough that residents have not seen most of it, which makes any question about how long you need partly unanswerable. What can be answered is how much a first visit can absorb before it stops being enjoyable, and the honest figure is more than the weekend most people allocate and less than the fortnight the city could fill.
What does three days cover?
The central core, if you group things geographically rather than chasing a list. One day for Westminster, taking in the Abbey, Parliament, St James's Park and Trafalgar Square. One for the City and Southwark, with St Paul's, the Tower, Borough Market and the South Bank.
The third is best spent on museums in South Kensington or on one neighbourhood such as Camden, Shoreditch or Greenwich. Three days is enough to feel you have seen London; it is not enough to feel you know it.
What does five days add?
Breathing room and the parts visitors usually miss. Five allows a proper day at the British Museum or the National Gallery rather than an hour, an afternoon in Hampstead or Richmond, a day trip to Greenwich by river, and time to sit in a pub rather than pass one.
It also absorbs the inevitable slow day. Somebody will be tired, it will rain, and a five day trip survives that where a three day trip does not.
Is a week too long?
No. A week allows a day trip out to Oxford, Cambridge, Windsor or Brighton, all under an hour and a half by train, while keeping London as the base. It also lets you see areas rather than sights.
The only visitors who find a week too long are those who have run out of a checklist and not found anything else. The city rewards curiosity considerably more than it rewards planning.
How should you structure the days?
By geography, without exception. London is around thirty miles across and crossing it repeatedly wastes hours. Group everything within walking distance of each other into a single day and accept that some famous things will fall on different days.
Assume that any single journey across central London takes thirty to forty five minutes door to door, and that three major indoor attractions in one day is one too many.
What is worth skipping?
Whatever you are only doing because it appears on lists. The London Eye is expensive and the view from the Sky Garden is free with a booking. Oxford Street is a shopping street of no particular distinction. Changing the Guard involves standing in a crowd for a brief and largely obscured ceremony.
The museums are the reverse: the British Museum, the National Gallery, the Tates, the Natural History Museum, the V and A and the Imperial War Museum are all free to enter and are among the best in the world.
How much does it cost?
Accommodation is the main expense and varies enormously by area and season. Transport is cheap by comparison, particularly with contactless payment, which caps daily and weekly spending automatically without any need to buy a pass.
A great deal of the best of London costs nothing: the parks, the national museums, the markets, the river walk and most of the churches. Paid attractions should be booked online in advance, where they are usually cheaper.
When should you go?
Spring and autumn give the best combination of weather, daylight and manageable crowds. Summer is busiest and hotel prices peak. Winter is cheapest outside the Christmas weeks, and the museums are at their most comfortable in January.
Whatever the season, book accommodation early and choose an area near a Tube line you will actually use rather than the cheapest postcode you can find.
What is the most common mistake?
Trying to see everything and crossing the city repeatedly to do it. Visitors routinely book a Westminster morning, a Tower of London afternoon and a Camden evening, then spend two hours underground linking them. London is a collection of neighbourhoods rather than a set of monuments, and the trips people remember are the ones where they walked one area properly rather than ticking off six. Pick a district each day, walk it, and accept that a first visit will leave a great deal unseen. It always does, and that is a reason to come back rather than a failure of planning.